[#ZF-9213] Zend_Db_Table_Rowset returns empty Zend_Db_Table_Row when acess negative index - Zend Framework Issue Tracker

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: 1.10.1
Fix Version/s: 1.10.7
Component/s: Zend_Db_Table
Labels:
None

Description

When acess negative index in rowset it should return null, because offset is inválid,but returns a row without data.
if access any position of a empty row it throws an exception.

Ex:

$table = new My_Table();//any table implementation
$rowset = $table->fetchAll();//return rowset
$row = $rowset[-1];//shold return null, but returns a Row without data

Issue Links

This issue depends on:
ZF-10173	Zend_Db_Table_Rowset_Abstract accepts indexes invalid.

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Ramon Henrique Ornelas added a comment - 19/Feb/10 7:03 AM

Current Code in Zend_Db_Table_Rowset_Abstract

public function valid()
{
        return $this->_pointer < $this->_count;
}

Should be

public function valid()
{
        return $this->_pointer >= 0 && $this->_pointer < $this->_count;
}

Show

Ramon Henrique Ornelas added a comment - 19/Feb/10 7:03 AM Current Code in Zend_Db_Table_Rowset_Abstract

public function valid()
{
        return $this->_pointer < $this->_count;
}

Should be

public function valid()
{
        return $this->_pointer >= 0 && $this->_pointer < $this->_count;
}

Hide

Permalink

Ramon Henrique Ornelas added a comment - 16/Jul/10 12:53 PM

Fixed with the r22582.

Show

Ramon Henrique Ornelas added a comment - 16/Jul/10 12:53 PM Fixed with the r22582.

People

Assignee:

Ramon Henrique Ornelas

Reporter:

Reinaldo Mendes

Vote (2)

Watch (1)

Dates

Created:

19/Feb/10 6:44 AM

Updated:

17/Jul/10 8:05 AM

Resolved:

16/Jul/10 12:53 PM