Zend Framework

Zend_Validate_Digits error text grammar can be improved

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.10.0
  • Fix Version/s: 1.10.2
  • Component/s: Zend_Validate
  • Labels:
    None

Description

The default text of Zend_Validate_Digits when validation isn't passed is the following:

  • '500.00' contains not only digit characters

An improvement might be something like:

  • '500.00' contains characters that are not digits; only digits are allowed

Attachments

  1. Text File
    ZF-9032.patch
    20/Feb/10 6:52 PM
    2 kB
    Wil Moore III (wilmoore)
  2. Text File
    ZF-9032.patch
    31/Jan/10 7:55 PM
    1 kB
    Wil Moore III (wilmoore)

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Wil Moore III (wilmoore) added a comment -

Includes enhancement and associated tests verified with "phpunit --testdox".

Show
Wil Moore III (wilmoore) added a comment - Includes enhancement and associated tests verified with "phpunit --testdox".
Hide
Permalink
Thomas Weidner added a comment -

Implemented with r21118

Show
Thomas Weidner added a comment - Implemented with r21118
Hide
Permalink
Wil Moore III (wilmoore) added a comment -

I've updated the patch against trunk as the english grammar was still a little odd. Please review.

Thanks.

Show
Wil Moore III (wilmoore) added a comment - I've updated the patch against trunk as the english grammar was still a little odd. Please review. Thanks.
Hide
Permalink
Thomas Weidner added a comment -

Fixed with r21136

Show
Thomas Weidner added a comment - Fixed with r21136

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Zend Framework. Try JIRA - bug tracking software for your team.