Zend Framework

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.9.7
• Fix Version/s: 1.10.2
• Component/s: Zend_Db
• Labels:

  None

In the fetchRow() method in Zend_Db_Table_Abstract I find this:

if (!($where instanceof Zend_Db_Table_Select)) {
    /* snip */
  } else {
    $select = $where->limit(1);
  }

So whenever you pass a Zend_Db_Table_Select object including a limit with an offset, say LIMIT 1 OFFSET 10, it overrules it with just LIMIT 1, even though in both cases the resulting rowset contains a maximum of 1 rows. This is unexpected and silently breaks the meaning of the select, resulting in a wrong row being returned.

Steps to reproduce:

$select = $teams->select()
  ->where('colour = ?', 'orange')
  ->order('result')
  ->limit(1,10);
		  
echo (string) $teams;
// SELECT `teams`.* FROM `teams` WHERE (colour = 'orange') ORDER BY `result` ASC LIMIT 1 OFFSET 10
		
$teams->fetchRow($teams);
// SELECT `teams`.* FROM `teams` WHERE (colour = 'orange') ORDER BY `result` ASC LIMIT 1

Suggested fix:

$select = $where->limit(1, $where->getPart(Zend_Db_Select::LIMIT_OFFSET));

1. 

   zf8944.r21084.patch

   18/Feb/10 2:07 PM

   1 kB

   Michael Rehbein

• Assignee:

  Mickael Perraud

  Reporter:

  Lauri Elevant

• Created:

  26/Jan/10 12:28 PM

  Updated:

  27/Apr/11 8:21 PM

  Resolved:

  19/Feb/10 1:17 PM