Details
-
Type:
Bug
-
Status:
Resolved
-
Priority:
Trivial
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 1.8.4
-
Component/s: Zend_Config
-
Labels:None
Description
Function "toArray()" is created with a foreach on "_data".
Interface "iterator" is implemented with : "next($this->_data)" and others functions of iterator directly on "_data".
My problem is function "toArray()" which is in conflict with the iterator interface.
For fix that , we must create a clone of object and after we can use "toArray()".
But function "toArray()" should be NOT in conflict with iterator ?
For me, the problem is not "toArray()" but the implement of "Iterator".
And is just when we want used "toArray()" AND iterator in same time on same object.
This problem could be apply to all classes with iterator and "toArray()".
But I don't know if it's a usage problem or a bug.
Nicolas CHOTIN.
Activity
Ok I see.
toArray() works directly on the _data array, and so does the iterator.
When calling toArray(), a foreach loop is used to iterate throught _data, that foreach loop first calls rewind() internaly , and then iterates. The problem is that the foreach loop leaves the array iterator at an undefinied position (that's why rewind() is called by foreach before the iteration).
Then when you call current() on your object, it just says it doesn't have a current value.
$config = new Zend_Config(array(1,2,3)); $config->rewind(); // rewound $config->toArray(); // the internal iterator is somewhere after the last position due to foreach loop assert($config->current() == false); // OK
To see that, create a getIndex() method in Zend_Config, which return $_index; and try this :
$config = new Zend_Config(array(1,2,3)); $config->rewind(); // rewound $config->toArray(); // the internal iterator is somewhere after the last position due to foreach loop assert($config->key() == $config->getIndex()); // WRONG , $config->key() returns NULL while getIndex() has the right value
The patch is easy, trigger the internal PHP copy-on-write system to make foreach loop over a copy of the _data array, and not the real _data.
Just add :
public function toArray() { $array = array(); + $data = $this->_data; foreach ($this->_data as $key => $value) { if ($value instanceof Zend_Config) { $array[$key] = $value->toArray(); } else { $array[$key] = $value; } } return $array; }
Even not using the new $data variable created, it increments the internal refcount on the _data structure, making foreach use a copy of it 
$config = new Zend_Config(array(1,2,3)); $config->rewind(); // rewound $config->toArray(); // the internal iterator is somewhere after the last position due to foreach loop assert($config->current() == false); // OK
$config = new Zend_Config(array(1,2,3)); $config->rewind(); // rewound $config->toArray(); // the internal iterator is somewhere after the last position due to foreach loop assert($config->key() == $config->getIndex()); // WRONG , $config->key() returns NULL while getIndex() has the right value
public function toArray() { $array = array(); + $data = $this->_data; foreach ($this->_data as $key => $value) { if ($value instanceof Zend_Config) { $array[$key] = $value->toArray(); } else { $array[$key] = $value; } } return $array; }
Would you mind providing the code you're using along with the results you're getting and the results you are expecting?
Thanks,
Rob...