Details
Bug
Resolved
Blocker
Description
The class : Zend_Amf_Parse_Amf3_Serializer doesn't support cyclic references. (I didn't test the Zend_Amf_Parse_Amf0_Serializer).
Problem sample :
class ServiceProvider
{
/**
- @return TestObject
*/
public function testGetRecursiveObject() { $o = new TestObject(); $o->recursive = new TestObject(); $o->recursive->recursive = $o; return $o; }}
When you call testGetRecursiveObject() with an AMF request, the server doesn't respond. What is worse is that : on Win Vista the apache server stops running.
This problem is critical : no error is returned by the server.
The solution to solve this problem, is to use the "reference system" described in the AMF3 specifications.
I've tried to solve the problem myself but unfortunately without success : I think i didn't write the good code for writing the object reference on the output stream.
Here is the patch :
Index: Serializer.php
===================================================================
— Serializer.php (revision 14591)
+++ Serializer.php (working copy)
@@ -35,6 +35,8 @@
*/
class Zend_Amf_Parse_Amf3_Serializer extends Zend_Amf_Parse_Serializer
+ public function writeReference($object)
+ {
+ $this->_stream->writeByte(0x07);
+ $ref = & $object;
+ $ref = $ref << 1;
+ $this->writeInteger($ref);
+ }
+
+ private function referenceExist($object)
+ {
+ if(in_array($object, $this->_references, true)) {
+ return true;
+ } else {
+ $this->_references[] = $object;
+ return false;
+ }
+ }
+
/**
- Write object to ouput stream
*
@@ -258,6 +278,11 @@
*/
public function writeObject($object)
{
+ if($this->referenceExist($object)) { + $this->writeReference($object); + return $this; + }
+
$encoding = Zend_Amf_Constants::ET_PROPLIST;
$className = '';
Attachments
Activity
I've been looking into this further (we really need it to work so I'm trying to hack together a fix), and I'm really confused by how this works. We're sending amf3 requests from Flash, and they are certainly arriving as part of the request as amf 3 (error_log("client version $clientVersion"); ) in the readMessage method in Zend_Amf_Request definitely says 3. However, the $clientVersion variable is never promoted to a member variable - I see there's a $_clientType member, but that doesn't seem to get set, and defaults to 0.
Worse, the Amf3 Serializer never even gets included - putting an error_log call at the top of the file (outside the class even) , never shows up.
Looking through the code, I can't find any connection between getting an Amf3 request, and sending an Amf3 Response. The _handle method of the Server certainly wants to send back amf0, based on objectEncoding it gets from the request (which surely should be 3, since that's what $clientVersion is!?), and the only way I can see the Amf3 Serializer being loaded is in the Amf0 Serializer's writeAmf3TypeMarker method, which has a comment which says, "Once AMF3 is encountered it will not return to AMf0", yet I cannot find any code-evidence that is the case, and this method isn't being called anyway.
I'm sure I am just being dense and there's something silly we're doing wrong as nobody else seems to have a problem with amf3 
Is there any obvious way to force amf3, since setting the objectEncoding to 3 in Flash doesn't seem to work for us?
Is there any obvious way to force amf3, since setting the objectEncoding to 3 in Flash doesn't seem to work for us?
Manually applying the patch changes to the Amf0 Serializer just gives me client.data.underflow error, so that doesn't seem like a viable workaround 
This patch correct the problem