ZF-12323: Fix Windows newline issues

Issue Type:
Unit Tests: Problem
Created:
2012-07-05T16:24:55.000+0000
Last Updated:
2013-01-22T09:47:11.000+0000
Status:
Resolved
Fix version(s):
  • 1.12.2 (25/Feb/13)
Reporter:
Frank Brückner (frosch)
Assignee:
Frank Brückner (frosch)
Tags:
  • Zend_Navigation
  • FixForZF1.12
Related issues:
Attachments:

Description

The patch includes changes from "\n" to {{PHP_EOL}}.

Comments

Posted by Rob Allen (rob) on 2012-07-06T10:43:12.000+0000

Fixed in trunk r25018 and release-1.12 r25019

Posted by Martin Hujer (mhujer) on 2012-07-11T07:41:02.000+0000

I'm afraid that this broke tests on my Windows. (Windows 7 HP 64bit, PHP 5.3.8, PHPUnit 3.4.15)

Posted by Martin Hujer (mhujer) on 2012-07-11T07:41:42.000+0000

This fixes failing tests for me.

Posted by Frank Brückner (frosch) on 2012-07-11T07:51:37.000+0000

Hi Martin, normally I work on Mac OS X, but after some tests with a old windows machine (Windows XP, PHP 5.2.17, PHPUnit 3.4), I had some errors.

I'll be looking at that again. Thanks for your feedback!

Posted by Frank Brückner (frosch) on 2013-01-22T09:47:11.000+0000

Was fixed with ZF-8874.